From db7e1f08a9cde91d3c2a47d2f5c4120b31b24c71 Mon Sep 17 00:00:00 2001 From: Ryan Walberg Date: Fri, 10 May 2024 18:02:29 -0400 Subject: [PATCH] cleaner way to do that --- src/item.php | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/item.php b/src/item.php index 479ad9f..d5964b3 100644 --- a/src/item.php +++ b/src/item.php @@ -181,13 +181,8 @@ if (!empty($_REQUEST["action"])) { } else if ($action == "insert") { if (!$haserror) { - if (isset($image_base_filename) && $image_base_filename != "") { - $stmt = $smarty->dbh()->prepare("INSERT INTO {$opt["table_prefix"]}items(userid,description,price,source,category,url,ranking,comment,quantity,image_filename) " . - "VALUES(?, ?, ?, ?, ?, ?, ?, ?, ?, ?)"); - } else { - $stmt = $smarty->dbh()->prepare("INSERT INTO {$opt["table_prefix"]}items(userid,description,price,source,category,url,ranking,comment,quantity) " . - "VALUES(?, ?, ?, ?, ?, ?, ?, ?, ?)"); - } + $stmt = $smarty->dbh()->prepare("INSERT INTO {$opt["table_prefix"]}items(userid,description,price,source,category,url,ranking,comment,quantity,image_filename) " . + "VALUES(?, ?, ?, ?, ?, ?, ?, ?, ?, ?)"); $stmt->bindParam(1, $userid, PDO::PARAM_INT); $stmt->bindParam(2, $description, PDO::PARAM_STR); $stmt->bindParam(3, $price); @@ -197,9 +192,10 @@ if (!empty($_REQUEST["action"])) { $stmt->bindParam(7, $ranking, PDO::PARAM_INT); $stmt->bindParam(8, $comment, PDO::PARAM_STR); $stmt->bindParam(9, $quantity, PDO::PARAM_INT); - if (isset($image_base_filename) && $image_base_filename != "") { - $stmt->bindParam(10, $image_base_filename, PDO::PARAM_STR); - } + if (!isset($image_base_filename) || $image_base_filename == "") { + $image_base_filename = NULL; + } + $stmt->bindParam(10, $image_base_filename, PDO::PARAM_STR); $stmt->execute(); stampUser($userid, $smarty->dbh(), $smarty->opt());